Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --view-key option to CLI commands as an alternative to --private-key for read-only operations. Users can now provide either a view key or a private key for commands that don't require spend authority.
Changes:
- Added
resolve_view_pairfunction to handle view key or private key input - Updated 14 CLI commands to accept optional
--view-keyparameter with mutual exclusivity constraints - Modified command handlers to use the new resolution logic
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cli/src/args.rs | Added optional view_key parameter to 14 commands with required_unless_present constraints for mutual exclusivity with private_key |
| cli/src/format.rs | Implemented viewkey_to_viewpair and resolve_view_pair functions to convert view keys to ViewPair and handle input resolution |
| cli/src/main.rs | Updated command handlers to use resolve_view_pair instead of direct privkey_to_keypair calls, and added import for the new function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code